-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eslint warnimg #3709
Fix eslint warnimg #3709
Conversation
So, I don't agree with this approach. I think the better way is to figure out what That is, someone should log all these cases of |
Thanks for doing this research! |
What: fix #3224
Why:
How:
Use a new utils function replace
v == null
to fix eslint warning.It's a code style issue. We also can chage ESlint config option "no-eq-null" to fix it. Which plan are we going to take? I will update my pr if it needs to change.
Checklist: